Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stepper): disconnects observer when component is disconnected #8013

Merged
merged 2 commits into from
Oct 16, 2023
Merged

refactor(stepper): disconnects observer when component is disconnected #8013

merged 2 commits into from
Oct 16, 2023

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #N/A

Summary

Disconnects observer when component is disconnected from the DOM.

@anveshmekala anveshmekala marked this pull request as ready for review October 13, 2023 23:27
@anveshmekala anveshmekala requested a review from a team as a code owner October 13, 2023 23:27
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Oct 13, 2023
@anveshmekala anveshmekala added skip visual snapshots Pull requests that do not need visual regression testing. low risk Issues with low risk for consideration in low risk milestones labels Oct 13, 2023
@anveshmekala anveshmekala mentioned this pull request Oct 13, 2023
Merged
@anveshmekala anveshmekala merged commit 9ca3d5f into main Oct 16, 2023
10 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/refactor-stepper-disconnect-observer branch October 16, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@anveshmekala anveshmekala

Labels
low risk Issues with low risk for consideration in low risk milestones refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @jcfranco